gitadora: warn about 2ch audio option not working on arena model (#702)

shrug
This commit is contained in:
bicarus
2026-05-25 17:00:49 -07:00
committed by GitHub
parent 3c60f3966b
commit 2b930ad95f
2 changed files with 26 additions and 19 deletions
+17 -11
View File
@@ -8,6 +8,7 @@
#include "misc/wintouchemu.h" #include "misc/wintouchemu.h"
#include "overlay/overlay.h" #include "overlay/overlay.h"
#include "util/cpuutils.h" #include "util/cpuutils.h"
#include "util/deferlog.h"
#include "util/detour.h" #include "util/detour.h"
#include "util/libutils.h" #include "util/libutils.h"
#include "util/logging.h" #include "util/logging.h"
@@ -605,33 +606,38 @@ namespace games::gitadora {
#endif #endif
} }
return;
} }
HMODULE gdme_module = libutils::try_module("libgdme.dll");
// window patch // window patch
if (!is_arena_model()) {
HMODULE gdme_module = libutils::try_module("libgdme.dll");
if (GRAPHICS_WINDOWED && !replace_pattern( if (GRAPHICS_WINDOWED && !replace_pattern(
gdme_module, gdme_module,
"754185ED753D8B4118BF0000CB02", "754185ED753D8B4118BF0000CB02",
"9090????9090??????????????12", 0, 0)) "9090????9090??????????????12", 0, 0)) {
{
log_warning("gitadora", "windowed mode failed"); log_warning("gitadora", "windowed mode failed");
} }
}
HMODULE bmsd_engine_module = libutils::try_module("libbmsd-engine.dll");
HMODULE bmsd_module = libutils::try_module("libbmsd.dll");
// two channel mod // two channel mod
if (TWOCHANNEL) { if (TWOCHANNEL) {
bmsd2_boot_orig = detour::iat_try("bmsd2_boot", bmsd2_boot_hook, bmsd_module); if (is_arena_model()) {
log_warning("gitadora", "two channel audio (-2ch) is not supported on Arena Model - use a patch instead");
deferredlogs::defer_error_messages({
"two channel audio (-2ch) is not supported on Arena Model - use a patch instead",
});
} else {
HMODULE bmsd_engine_module = libutils::try_module("libbmsd-engine.dll");
HMODULE bmsd_module = libutils::try_module("libbmsd.dll");
bmsd2_boot_orig = detour::iat_try("bmsd2_boot", bmsd2_boot_hook, bmsd_module);
if (!(replace_pattern(bmsd_engine_module, "33000000488D", "03??????????", 0, 0) || if (!(replace_pattern(bmsd_engine_module, "33000000488D", "03??????????", 0, 0) ||
replace_pattern(bmsd_engine_module, "330000000F10", "03??????????", 0, 0))) replace_pattern(bmsd_engine_module, "330000000F10", "03??????????", 0, 0))) {
{
log_warning("gitadora", "two channel mode failed"); log_warning("gitadora", "two channel mode failed");
} }
} }
}
#endif #endif
+3 -2
View File
@@ -1038,9 +1038,10 @@ static const std::vector<OptionDefinition> OPTION_DEFINITIONS = {
.category = "Game Options (Advanced)", .category = "Game Options (Advanced)",
}, },
{ {
.title = "GitaDora Two Channel Audio", .title = "GitaDora Two Channel Audio (DX/SD only)",
.name = "2ch", .name = "2ch",
.desc = "Attempt to reduce audio channels down to just two channels.", .desc = "Attempt to reduce audio channels down to just two channels. "
"This option does nothing for Arena Model (GW Delta and above); need a patch for that.",
.type = OptionType::Bool, .type = OptionType::Bool,
.game_name = "GitaDora", .game_name = "GitaDora",
.category = "Game Options", .category = "Game Options",