Fix last character being truncated in clipboard::copy_text due to off-by-one error (#262)

## Link to GitHub Issue, if one exists
n/a, user reported

## Description of change
When copying text to clipboard, the last character was being dropped due
to incorrect string buffer size calculation.

Also, clean up callers to just pass std:string by reference instead of
going back and forth between C-style strings.

Lastly, fix `git archive` in `build_all.sh` which broke after github
migration.

## Compiling
Yes

## Testing
Tested all three callers - IIDX cam hook, scard reader in Cards tab, and
patch manager datecode.

src/spice2x/overlay/windows/config.cpp

@@ -2524,7 +2524,7 @@ namespace overlay::windows {
                         );
                     ImGui::SameLine();
                     if (ImGui::Button("Copy")) {
-                        clipboard::copy_text(card_str.c_str());
+                        clipboard::copy_text(card_str);
                     }
                     ImGui::SameLine();
                     if (ImGui::Button("Clear")) {