From 74e619df3792a3f804fac6d0be2f7beed7f5e5c1 Mon Sep 17 00:00:00 2001 From: bicarus <202771338+bicarus-dev@users.noreply.github.com> Date: Sun, 26 Jul 2026 16:16:25 -0700 Subject: [PATCH] sdvx: fix check for enable_console in avs_config.xml (#838) ## Link to GitHub Issue or related Pull Request, if one exists Regressed by #657 ## Description of change Workaround for SDVX4 was applied too broadly and caused sdvx 1/2/3 to not boot, depending on contents of avs-config.xml. `property_search_safe` throws a fatal error if the node is not present. What we wanted to do was to check for presence. ## Testing sanity checked sdvx 1/2/3/4 --- src/spice2x/avs/core.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/spice2x/avs/core.cpp b/src/spice2x/avs/core.cpp index 5fafcaf..23f77e0 100644 --- a/src/spice2x/avs/core.cpp +++ b/src/spice2x/avs/core.cpp @@ -1924,7 +1924,7 @@ namespace avs { #if !SPICE64 // sdvx4 bad log config fix if (avs::game::DLL_NAME == "soundvoltex.dll" && // it's too early for avs::game::is_model - property_search_safe(config, config_node, "/log/enable_console")) { + property_search(config, config_node, "/log/enable_console")) { log_info("avs-core", "applying SDVX4 avs-config.xml fix for "); property_search_remove_safe(config, config_node, "/log/enable_console"); }