From 88ec6dbcee94ec56c56b30a64c7c514e51706ea2 Mon Sep 17 00:00:00 2001 From: bicarus-dev <202771338+bicarus-dev@users.noreply.github.com> Date: Fri, 7 Nov 2025 14:20:37 -0800 Subject: [PATCH] launcher: hide pcbid when -cmdoverride specified (#420) ## Link to GitHub Issue, if one exists Fixes #419 ## Description of change -cmdoverride caused pcbid to be logged in plain text ## Testing --- src/spice2x/launcher/launcher.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/spice2x/launcher/launcher.cpp b/src/spice2x/launcher/launcher.cpp index 7e4b2be..4569e7b 100644 --- a/src/spice2x/launcher/launcher.cpp +++ b/src/spice2x/launcher/launcher.cpp @@ -1262,18 +1262,19 @@ int main_implementation(int argc, char *argv[]) { for (const auto &option : options) { if (option.conflicting && option.get_definition().type != OptionType::Bool) { conflicts += 1; + const auto& value = option.get_definition().sensitive ? "*****" : option.value; if (launcher::USE_CMD_OVERRIDE) { log_warning( "launcher", "multiple values for -{}, command line args take precedence: {}", option.get_definition().name, - option.value); + value); } else { log_warning( "launcher", "multiple values for -{}, spicecfg values take precedence: {}", option.get_definition().name, - option.value); + value); } } }