mirror of
https://github.com/spice2x/spice2x.github.io.git
synced 2026-08-01 22:30:42 -07:00
patcher: load auto-enable settings even if dest/spec/rev don't match (#527)
## Link to GitHub Issue, if one exists n/a ## Description of change Before this change, if user changes `dest`/`spec`/`rev`, then the "auto enable patches" settings doesn't get loaded. This is because the patch manager config file relies on having an exact match of `model+dest+spec+rev+ext`. This causes a lot of confusion for: * people who edit prop files - e.g., to switch between sdvx nemsys/valk cab modes - and forget to re-enable patches * people who use batch scripts to change xml files on launch - e.g., for gitadora, omnimix, etc - even if they checked auto-apply in spicecfg, when they use the batch script to launch the game, the setting won't be loaded This PR solves this by just ignoring the `dest`/`spec`/`rev` fields when checking if patches should be auto applied on launch. Yes, this may cause false positive cases, but probably very unlikely, and it's pretty harmless anyway. For future consideration: should we fix up gitadora XG disparity (K32 vs K33 etc)? ## Testing Manually validated
This commit is contained in:
@@ -143,6 +143,8 @@ namespace overlay::windows {
|
||||
std::string pe_identifier_for_patch = "");
|
||||
|
||||
void show_patch_tooltip(const PatchData& patch);
|
||||
|
||||
bool is_game_id_wildcard_matched(const std::string& id_from_config);
|
||||
};
|
||||
|
||||
PatchStatus is_patch_active(PatchData &patch);
|
||||
|
||||
Reference in New Issue
Block a user