From a0a7b865088d19cfcc2c203461e2dd9a19247df3 Mon Sep 17 00:00:00 2001 From: Will Date: Sat, 7 Mar 2026 13:05:44 +1000 Subject: [PATCH] ddr p3io: fix neon pulse mapping (#566) Logic was wrong; caught by compiling with a newer clang and it raising a warning about the useless expression (since the second clause always eval'd as true). Changed to the intended functionality, but I have no ddr3 with p3io so I can't test it. But it seems nobody ever really noticed this. --- src/spice2x/games/ddr/p3io/p3io.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/spice2x/games/ddr/p3io/p3io.cpp b/src/spice2x/games/ddr/p3io/p3io.cpp index d896fd6..f2def76 100644 --- a/src/spice2x/games/ddr/p3io/p3io.cpp +++ b/src/spice2x/games/ddr/p3io/p3io.cpp @@ -282,7 +282,7 @@ int games::ddr::DDRP3IOHandle::write(LPCVOID lpBuffer, DWORD nNumberOfBytesToWri } // use both sat spots for a neon pulse - float value_neon = (light_bits & hd_mapping_bits[0] && hd_mapping_bits[1]) ? 1.f : 0.f; + float value_neon = (light_bits & hd_mapping_bits[0] && light_bits & hd_mapping_bits[1]) ? 1.f : 0.f; GameAPI::Lights::writeLight(RI_MGR, lights[Lights::NEON], value_neon); }