From da58503b47d600be9b2be3fc9c993806dd98f486 Mon Sep 17 00:00:00 2001 From: sp2xdev <127630192+sp2xdev@users.noreply.github.com> Date: Fri, 3 Oct 2025 00:07:54 -0700 Subject: [PATCH] use lock_guard and not unique_lock unless unlocking is needed --- src/spice2x/util/deferlog.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/spice2x/util/deferlog.cpp b/src/spice2x/util/deferlog.cpp index 21dd314..4c4f0bc 100644 --- a/src/spice2x/util/deferlog.cpp +++ b/src/spice2x/util/deferlog.cpp @@ -17,14 +17,14 @@ namespace deferredlogs { std::vector> deferred_errors; void defer_error_messages(std::initializer_list messages) { - std::unique_lock lock(deferred_errors_mutex); + std::lock_guard lock(deferred_errors_mutex); deferred_errors.emplace_back(messages); } void dump_to_logger() { static std::once_flag printed; std::call_once(printed, []() { - std::unique_lock lock(deferred_errors_mutex); + std::lock_guard lock(deferred_errors_mutex); if (!deferred_errors.empty()) { log_warning("deferred_error", "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!");