Compare commits

..

1 Commits

Author SHA1 Message Date
bicarus-dev 0684872013 fix error printing for dll info 2026-10-03 15:23:38 -07:00
+2 -6
View File
@@ -404,13 +404,11 @@ void libutils::print_dll_info(std::filesystem::path filename) {
const auto size = GetFileVersionInfoSizeW(filename.wstring().c_str(), &handle); const auto size = GetFileVersionInfoSizeW(filename.wstring().c_str(), &handle);
if (size == 0) { if (size == 0) {
const auto error = GetLastError(); const auto error = GetLastError();
const auto error_message = get_last_error_string();
log_misc( log_misc(
"libutils", "libutils",
"GetFileVersionInfoSizeW failed for {}: {} (Win32 error {}); " "GetFileVersionInfoSizeW failed for {}: Win32 error {}; "
"DLL may have no version resource", "DLL may have no version resource",
filename, filename,
error_message,
error); error);
print_summary(); print_summary();
return; return;
@@ -419,12 +417,10 @@ void libutils::print_dll_info(std::filesystem::path filename) {
auto data = util::make_unique_plain<VOID>(size); auto data = util::make_unique_plain<VOID>(size);
if (!GetFileVersionInfoW(filename.wstring().c_str(), handle, size, data.get())) { if (!GetFileVersionInfoW(filename.wstring().c_str(), handle, size, data.get())) {
const auto error = GetLastError(); const auto error = GetLastError();
const auto error_message = get_last_error_string();
log_misc( log_misc(
"libutils", "libutils",
"GetFileVersionInfoW failed for {}: {} (Win32 error {})", "GetFileVersionInfoW failed for {}: Win32 error {}",
filename, filename,
error_message,
error); error);
print_summary(); print_summary();
return; return;