use lock_guard and not unique_lock unless unlocking is needed

This commit is contained in:
sp2xdev
2025-10-03 00:07:54 -07:00
parent cffee2b7f8
commit da58503b47
+2 -2
View File
@@ -17,14 +17,14 @@ namespace deferredlogs {
std::vector<std::vector<std::string>> deferred_errors; std::vector<std::vector<std::string>> deferred_errors;
void defer_error_messages(std::initializer_list<std::string> messages) { void defer_error_messages(std::initializer_list<std::string> messages) {
std::unique_lock<std::mutex> lock(deferred_errors_mutex); std::lock_guard<std::mutex> lock(deferred_errors_mutex);
deferred_errors.emplace_back(messages); deferred_errors.emplace_back(messages);
} }
void dump_to_logger() { void dump_to_logger() {
static std::once_flag printed; static std::once_flag printed;
std::call_once(printed, []() { std::call_once(printed, []() {
std::unique_lock<std::mutex> lock(deferred_errors_mutex); std::lock_guard<std::mutex> lock(deferred_errors_mutex);
if (!deferred_errors.empty()) { if (!deferred_errors.empty()) {
log_warning("deferred_error", log_warning("deferred_error",
"!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!"); "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!");