Compare commits

..

5 Commits

Author SHA1 Message Date
sp2xdev ccf2009726 Update CONTRIBUTING.md 2024-07-27 18:50:20 -07:00
sp2xdev 0253cb84a7 Update README.md 2024-07-20 17:39:06 -07:00
sp2xdev 4d7017bd07 Update README.md 2024-07-20 17:38:17 -07:00
sp2xdev cb4bd6e80d Update README.md 2024-07-20 16:56:25 -07:00
sp2xdev 7ed33e261e Update README.md 2024-07-20 16:50:48 -07:00
2 changed files with 5 additions and 1 deletions
+2
View File
@@ -17,6 +17,8 @@ Additionally, there's a lot of code that get exercised on specific hardware - in
Therefore, when making code changes, please be extremely careful about containing / scoping your changes. Make targeted bug fixes scoped to handful of game versions and hardware configuration. When adding new features, make it off by default, unless there is a really good reason to make it the default. If you make a new default, add an option that disables it so that users can opt out as needed.
Lastly, watch out for legacy OS compatibility. Currently, the minimum support floor is Windows 7. If you use any Windows API, make sure it's supported in Windows 7. If you need to use API that is not present in Windows 7, you must not directly link against it, otherwise spice will fail to launch on older OSes. Take a look at Windows 8 touch code (win8.cpp) for examples on how to discover OS APIs via pointers.
### Code quality requirements
* Test for regressions, at least in and around the component you are modifying:
+3 -1
View File
@@ -35,7 +35,9 @@ Rules for filing a new issue or adding comments to existing issues in the tracke
* Check the [known issues](https://github.com/spice2x/spice2x.github.io/wiki/Known-issues) page first before reporting a new issue.
* Use the search function and see if there is an existing issue.
* This is not the place to obtain a guide or receive basic troubleshooting.
* **Do not link to external websites that distribute game data!**
* Don't file a bug demanding game XYZ to be supported.
* **Do not upload game data - any part of it, XML files included!**
* **Do not mention or link to external websites that distribute game data!**
* **Do not link to external websites that provide guides on how to run games!**
New GitHub accounts are prevented from creating new issues to prevent spam. Maintainers of this project reserve the right to close or delete any issues that violate the rules above, or low effort issues.